Migrate discord OAuth to fastapi #50
Conversation
takos22
left a comment
takos22
left a comment
There was a problem hiding this comment.
Change validation to pydantic and change some things.
takos22
left a comment
takos22
left a comment
There was a problem hiding this comment.
Some doc changes are needed but otherwise lgtm
|
And fix the checks |
| @click.option("-h", "--host", default="127.0.0.1") | ||
| @click.option("-d", "--debug", default=False, is_flag=True) | ||
| @click.option("-i", "--initdb", default=False, is_flag=True) | ||
| @click.option("-r", "--reload", default=False, is_flag=True) |
There was a problem hiding this comment.
Could make it a resetdb command, I've found it useful in testing from time to time.
There was a problem hiding this comment.
This can be added in another pr
|
@mohamed040406 are you planning to do the changes or should someone else do them? |
technically anyone can do them 👀 |
takos22
left a comment
takos22
left a comment
There was a problem hiding this comment.
lgtm except for import orders
api/app.py
Outdated
| from utils.response import JSONResponse | ||
| from aiohttp import ClientSession | ||
| from api import versions | ||
| import logging |
There was a problem hiding this comment.
Ordering isn't logical at all, ordering by length doesn't make sense to me. Order by first party, third party and local packages and in each of them put imports then from ... imports and each of these categories order alphabetically or just use isort.
3 participants
Summary
Migrate discord OAuth from quart to fastapi
Checklist